[docker] update dockerfiles, add formosa docker#840
Merged
Conversation
fdupress
added
chore
fdupress
force-pushed
the
jasmin-docker
branch
from
8332d98 to
e9781be
Compare
strub
approved these changes
Dec 1, 2025
Member
|
@fdupress Could you update the PR description. It is used for generating the ChangeLog if I remember well. |
Member
Author
|
Sorry, this one should have been draft. I want to merge the other (#842) first. (And yes, I will make the description clearer.) Only the title appears in the changelog, though. |
Member
Author
|
@strub do you want this squashed? The first commit is just updating existing Dockerfiles to work without warning or error after docker and opam updates in the ubuntu LTS, so it feels independent. |
fdupress
force-pushed
the
jasmin-docker
branch
from
e9781be to
08bc26d
Compare
fdupress
force-pushed
the
jasmin-docker
branch
from
08bc26d to
18f10b5
Compare
Member
|
Ok to merge without squashing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a Dockerfile that includes the dependencies for a jasmin toolchain—the latest release at time of build. This is (mainly) to reasonably allow
formosarepos to be added to our external CI without requiring that their extracted code be version controlled. (See #725, for example.)This also parameterizes the container Makefile with a
TAGenvironment variable, which is intended to (later) be set as the branch name, so we can publish containers formain, containers for named releases, and containers for the currentlatest. (See also #842.)